BUG Compatibility with 4.0 AsetStore API #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tractorcow
commented
Feb 24, 2016
tractorcow
commented
- Don't delete Folders (managed by backend)
- Fix deletion to match correct columns
- New assertion for matching files by filename and hash
- Skip createdFilesPath - Managed by backend not by behat anymore
tractorcow
pushed a commit
to open-sausages/silverstripe-cms
that referenced
this pull request
Feb 24, 2016
- Don't delete Folders (managed by backend) - Fix deletion to match correct columns - New assertion for matching files by filename and hash - Skip createdFilesPath - Managed by backend not by behat anymore
tractorcow
force-pushed
the
pulls/fix-asset-store
branch
from
1a70524
to
58b1d87
Compare
|
I have no idea what's going on with these tests. |
|
Merging, since tests were already broken in master |
chillu
added a commit
that referenced
this pull request
Feb 24, 2016
BUG Compatibility with 4.0 AsetStore API
|
Right. :) I tested at https://travis-ci.org/tractorcow/silverstripe-behat-extension/jobs/111372840 to prove it :P |
tractorcow
pushed a commit
to open-sausages/silverstripe-cms
that referenced
this pull request
Feb 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.