-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with advancedworkflow #15
Comments
I hope we can do this in a minor release of the advancedworkflow module, which means we could introduce this feature in the CWP 2.x release line at some point next year. The data model stays the same, it's just the extension names which change (and we can fix that through subclasses). YAML config keys would need to be adjusted. So we'd add this module to our supported modules under CWP, instead of maintaining the same code twice. |
@chillu I believe support for Workflow should be possible once I have merged: Model should store separate "desired" dates (yet to be approved) from actual statesI've added matching fields:
Only the approval should trigger a queued jobAs part of Hide schedule date fields if "desired" dates are setI don't think there is anything for me to change here. I'm exposing fields that are relevant given the current Object state and whether or not editing during embargo is allowed. Define if record can be edited during embargo in workflow actionAs part of this module's Migration path shouldn't be requiredI believe this is true. As you say, they use the same fields. |
This module essentially duplicates a subset of the features in https://github.com/symbiote/silverstripe-advancedworkflow/, without coupling them to workflow concerns. Ideally we wouldn't need this duplication - the module maintainer Marcus agrees that we should split out the feature as well.
Missing features in new module (or bridge to advancedworkflow):
Existing discussions:
symbiote/silverstripe-advancedworkflow#47
symbiote/silverstripe-advancedworkflow#187
The text was updated successfully, but these errors were encountered: