Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailto link do not work #235

Closed
maxime-rainville opened this issue Sep 28, 2021 · 2 comments · Fixed by #240
Closed

Mailto link do not work #235

maxime-rainville opened this issue Sep 28, 2021 · 2 comments · Fixed by #240

Comments

@maxime-rainville
Copy link
Contributor

maxime-rainville commented Sep 28, 2021

If you look at this article in tho doc, you'll notice that the email link is actually rendered as a regular link: https://docs.silverstripe.org/en/4/contributing/issues_and_bugs/#reporting-security-issues

[security@silverstripe.org](mailto:security@silverstripe.org) in Markdown points to https://docs.silverstripe.org/en/4/contributing/mailto:security@silverstripe.org/

PRs

@dhensby
Copy link
Contributor

dhensby commented Jan 17, 2022

I think email addresses should just be auto-linked as is, so that link style can just be taken out

@GuySartorelli
Copy link
Member

Created a PR for this - we could go and update the docs to not use links, but someone can just as easily add one in the future and then we're stuck back in the same situation. May as well just fix it outright.

@GuySartorelli GuySartorelli linked a pull request May 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants