Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelogs order is incorrect #237

Closed
GuySartorelli opened this issue Feb 14, 2022 · 1 comment · Fixed by #239
Closed

Changelogs order is incorrect #237

GuySartorelli opened this issue Feb 14, 2022 · 1 comment · Fixed by #239

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Feb 14, 2022 •
edited

In the changelogs index 4.11.0 and 4.10.0 should be at the top, but they're buried down below 4.2.0

PRs
@GuySartorelli GuySartorelli changed the title Change log order is incorrect Changelogs order is incorrect Feb 14, 2022
@GuySartorelli
Copy link
Member Author

It seems like (on the master branch - the most recent tag is super old so I am assuming that the website is just running the master branch) this sorting is ultimately handled by https://github.com/silverstripe/doc.silverstripe.org/blob/master/src/utils/sortFiles.ts which looks like it should give the correct sort order :/ Not sure what's happening here.

@GuySartorelli GuySartorelli mentioned this issue May 5, 2022
Merged
@GuySartorelli GuySartorelli linked a pull request May 5, 2022 that will close this issue
FIX Ensure changelogs are sorted correctly. #239
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX Ensure changelogs are sorted correctly. creative-commoners/doc.silverstripe.org
1 participant
@GuySartorelli