Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node12 github actions are deprecated - will stop working mid 2023 #50

Closed
1 task done
GuySartorelli opened this issue Oct 11, 2022 · 3 comments
Closed
1 task done
Assignees

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 11, 2022

https://github.com/silverstripe/silverstripe-installer/actions/runs/3220762331
Github actions is throwing some warnings at us:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/checkout

It says it'll stop working in "Summer 2023" which means june-ish

Acceptance criteria

  • any action currently using node12 is updated to use the latest runner.

Notes

  • We should still be able to use older version of node for our builds. Just not for the actual runner.
  • Note should be able to update the central github actions without having to update every single builds.

PRs

@GuySartorelli GuySartorelli changed the title node12 github actions are deprecated node12 github actions are deprecated - will stop working mid 2023 Apr 27, 2023
@GuySartorelli GuySartorelli self-assigned this May 3, 2023
@GuySartorelli GuySartorelli removed their assignment May 3, 2023
@emteknetnz emteknetnz self-assigned this May 8, 2023
@emteknetnz
Copy link
Member

Have merged and released all prs

@GuySartorelli
Copy link
Member Author

Reopened to verify that the deprecation notices are gone

@GuySartorelli
Copy link
Member Author

Deprecation notices aren't being emitted anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants