Hyphens in managed_models keys cause errors

[andrewandante]

According to the docs we should be able to have a $managed_models key like so:

        'product-category' => [
            'dataClass' => Category::class,
            'title' => 'Product categories'
        ]

However, adding one always results in the error: ModelAdmin::init(): Invalid Model class

I believe this is due to the unsanitiseClassName() call but I'm setting out to prove it shortly.

Pull request

• NEW Add dedicated controller to displays errors in CMS #1218

[maxime-rainville]

One of the test added by the PR is failing the build on the kitchen sink.

1) SilverStripe\Admin\Tests\ModelAdminTest::testMultiModelAdminOpensEachTab
BadMethodCallException: No session available for this HTTPRequest
/home/travis/build/silverstripe/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/Control/HTTPRequest.php:938
/home/travis/build/silverstripe/cwp-recipe-kitchen-sink/vendor/silverstripe/admin/code/LeftAndMain.php:1667
/home/travis/build/silverstripe/cwp-recipe-kitchen-sink/vendor/silverstripe/admin/code/LeftAndMain.php:1695
/home/travis/build/silverstripe/cwp-recipe-kitchen-sink/vendor/silverstripe/subsites/src/Extensions/LeftAndMainSubsites.php:314
/home/travis/build/silverstripe/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/Core/Extensible.php:468
/home/travis/build/silverstripe/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/Control/Controller.php:123
/home/travis/build/silverstripe/cwp-recipe-kitchen-sink/vendor/silverstripe/admin/tests/php/ModelAdminTest.php:48
/home/travis/build/silverstripe/cwp-recipe-kitchen-sink/vendor/sminnee/phpunit/phpunit:52

[emteknetnz]

Have merged PR - rerunning kitchen-sink

If testMultiModelAdminOpensEachTab is resolved on build, then will close this issue

Last red build pre merge with failure - https://travis-ci.com/github/silverstripe/cwp-recipe-kitchen-sink/builds/228312788

Build post merge that's expected to go green - https://travis-ci.com/github/silverstripe/cwp-recipe-kitchen-sink/builds/228395717

[emteknetnz]

@maxime-rainville - re-run did not fix issue https://travis-ci.com/github/silverstripe/cwp-recipe-kitchen-sink/jobs/512232011

[maxime-rainville]

Third time is the charm #1228