Skip to content

Commit

Permalink
BUG Restrict URLSegment preview to editable fields
Browse files Browse the repository at this point in the history
This fixes a bug where the Translatable module
would have a duplicate preview because it had
another ".urlsegment" field showing the value in its
original language.

See silverstripe/silverstripe-translatable#43
  • Loading branch information
chillu committed Aug 16, 2012
1 parent f5007a5 commit 2923e55
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions javascript/SiteTreeURLSegmentField.js
Expand Up @@ -11,9 +11,13 @@
* Constructor: onmatch
*/
onmatch : function() {
this._addActions(); // add elements and actions for editing
this.edit(); // toggle
this._autoInputWidth(); // set width of input field
// Only initialize the field if it contains an editable field.
// This ensures we don't get bogus previews on readonly fields.
if(this.find(':text').length) {
this._addActions(); // add elements and actions for editing
this.edit(); // toggle
this._autoInputWidth(); // set width of input field
}

this._super();
},
Expand Down

0 comments on commit 2923e55

Please sign in to comment.