Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with back office display after validation error #1130

Closed
dhminh opened this issue Nov 12, 2014 · 2 comments
Closed

Problem with back office display after validation error #1130

dhminh opened this issue Nov 12, 2014 · 2 comments
Labels

Comments

@dhminh
Copy link

dhminh commented Nov 12, 2014

Hi there,

I added 2 custom fields to Settings by the followings:

private static $db = array(
'Latitude' => 'Decimal',
'Longitude' => 'Decimal'
);
public function updateCMSFields(FieldList $fields) {
$fields->addFieldToTab("Root.Main", new NumericField("Latitude", "Latitude"));
$fields->addFieldToTab("Root.Main", new NumericField("Longitude", "Longitude"));
}

Everything seems ok until I input string such as "abc" into these two fields (instead of numeric values). Back office shows "validation errors" right after that. This is right. But it displays the setting form unexpectedly.

2014-11-12_17h02_32

Seems that there is a problem with ui-tab. Below is how it looks before validation:

2014-11-12_16h43_34

Note that I did not make any changes except adding the two fields.
Did I miss anything?

@dakiquang
Copy link

Hi @dhminh,

I have caught same problem when validation failed in Setting page. Then, tabs will be lost when validation failed.

One more thing, validation error messages were not lost when I filled out and submitted again. Please my attached file

2014-11-12_16h47_00

@sminnee
Copy link
Member

sminnee commented May 25, 2017

This is much more solid in SS4, I think we've solved it.

@sminnee sminnee closed this as completed May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants