Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer versions for required modules are not restrictive enough #1601

Closed
oddnoc opened this issue Sep 6, 2016 · 3 comments
Closed

Composer versions for required modules are not restrictive enough #1601

oddnoc opened this issue Sep 6, 2016 · 3 comments

Comments

@oddnoc
Copy link

oddnoc commented Sep 6, 2016

Consider the required modules at tag 3.3.3:

"require": {
    "php": ">=5.3.3",
    "composer/installers": "*",
    "silverstripe/framework": "~3.3",
    "silverstripe/reports": "~3.3",
    "silverstripe/siteconfig": "~3.3"
},

Doing a composer update today brings in silverstripe/reports 3.4.1 and silverstripe/siteconfig 3.4.1. Unless this is intentional, the version constraints should be changed to "~3.3.0". This will allow the patch level to increase, but will keep the minor revision in sync with cms and framework.

Version 3.4.x of the CMS will run into this problem as soon as 3.5.0 is created.

I want to make sure this is actually a mistake/bug before proposing any patches. Thanks!

@dhensby
Copy link
Contributor

dhensby commented Sep 7, 2016

I believe this is as intended.

We implement semver and so this should technically work with any 3.x version of those modules.

Being flexible here allows other modules to be more strict and provides flexibility with compatibility with other modules.

You can always lock down your versions in your composer.json if it's a concern to you

@dhensby dhensby closed this as completed Sep 7, 2016
@lerni
Copy link
Contributor

lerni commented Sep 8, 2016

@oddnoc this one keeps latest of 3.3 "3.3.*@stable"

@dhensby
Copy link
Contributor

dhensby commented Sep 8, 2016

So does ~3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants