-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot embed YouTube link on CWP #2168
Comments
/cc @ishannz who is also affected by this. |
When this issue initially was raised with RC's our first guess was that the request isn't being correctly passed through the CWP proxy given the error message. The docs state that |
I created a pull request on silverstripe-asset-admin which hopefully would address the underlying issue. We'd still need to reference that somewhere in the CWP recipe. |
All PRs added to issue description |
@robbieaverill All reviewed so should be good for a core committer to merge them all |
Thanks @lukereative |
All PRs merged, fixes will be available in 4.1.x and 4.2.x (incl. CWP 2.1.0) |
We are getting this issue again, confirmed in a couple of environments. Is this a regression perhaps? |
Confirmed the regression with CWP 2.1.0 and CWP 2.1.1-rc2. I'll investigate further today with help from SilverStripe Platform team. |
Sorry, I'm mistaken. I can't reproduce this any longer on CWP 2.1.1-rc2. @katieelks can you please ask one of your devs to add the missing error logging configuration from CWP 2.x (see silverstripe/cwp-core#43) and re-deploy, then try again? This should mean you get some debugging information in Graylog. |
For reference: after a few iterations, a fix that was originally applied to config in cwp-recipe-cms was moved to cwp-core to ensure it would be picked up by all CWP sites regardless of other modules that are installed. This was released for CWP 2.1.1 in early September. |
We have CWP 2.1 installed: in cwp-recipe-cms: ---
Name: cwpoembedconfig
After: coreoembed
Except:
environment: dev
Only:
EnvVarSet: SS_OUTBOUND_PROXY
---
SilverStripe\Core\Injector\Injector:
# Configure the CWP proxy if defined
Embed\Http\DispatcherInterface:
class: Embed\Http\CurlDispatcher
constructor:
config:
# CURLOPT_PROXY = 10004
10004: '`SS_OUTBOUND_PROXY`'
# CURLOPT_PROXYPORT = 59
59: '`SS_OUTBOUND_PROXY_PORT`'
# Provide dispatcher to Embeddable implementations
SilverStripe\View\Embed\Embeddable:
properties:
Dispatcher: '%$Embed\Http\DispatcherInterface'
so:
We are on: cwp/cwp 2.1.1
cwp/cwp-core 2.1.1
cwp/cwp-pdfexport 1.0.1
cwp/cwp-recipe-cms 2.1.1
cwp/cwp-recipe-core 2.1.1 |
@sunnysideup just checking you resolved this by copying the config into your project as noted on the other issue? |
@robbieaverill - yes, that is now working. Thank you |
Environment:
Steps:
Expected:
Actual:
Reported by @emteknetnz via SilverStripe Ops, supposedly works correctly on localhost. This could possibly be an Incapsula issue?
Pull requests
The text was updated successfully, but these errors were encountered: