Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs get overlayed #2405

Closed
emteknetnz opened this issue Apr 3, 2019 · 8 comments
Closed

Tabs get overlayed #2405

emteknetnz opened this issue Apr 3, 2019 · 8 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Apr 3, 2019

SilverStripe 4.3.1

I've seen this sort of thing several times

In this particular instance, it's editable a user form (content block)

image

It seems like the <div class="cms-content-header-tabs"> that contains the tabs are in the wrong place

image

Perhaps:

  • toolbar
    --> cms-content-header-tabs
  • panel

Should be:

  • toolbar
  • panel
    --> cms-content-header-tabs
@chillu
Copy link
Member

chillu commented Apr 9, 2019

@emteknetnz What version of userforms is that? I can't reproduce this on 4.3.x-dev (through https://github.com/silverstripe/cwp-recipe-kitchen-sink)

image

@emteknetnz
Copy link
Member Author

Don't know which version of userforms sorry, I should have recorded that info at the time. I've now lost context of which website I saw this behaviour on

@chillu
Copy link
Member

chillu commented Jun 20, 2019

OK, I'm closing until somebody can tell me a composer info to reproduce this on

@chillu chillu closed this as completed Jun 20, 2019
@brynwhyman
Copy link

I saw this recently too, so have reconfirmed. It's two-fold:

  • silverstripe/userforms 5.4.x-dev and silverstripe/cms 4.4.x-dev breaks at mobile resolutions only (<465px wide)
  • dnadesign/silverstripe-elemental-userforms 3.0.x-dev breaks at a much wider view (<933px wide) - likely what @emteknetnz encountered. Although when building a userform with this module, split mode isn't available, so it seems unlikely that a user would see this view.

Will leave for @chillu to reopen, if required.

@chillu chillu reopened this Jun 25, 2019
@JakubDolba
Copy link

Reproducible with silverstripe/framework 4.3.x and any silverstripe/admin (probably all framework 4.x)

  • just use any browser dev console and manually add few more tab-menu li items into ul in cms-tabset-nav-primary and adjust browser window width
  • not related to user-forms

@brynwhyman
Copy link

We've had further reports of this bug,

they have quite a lot of menu-items and it is broken (easily reproducible in any browser)

@samandeggs
Copy link

Having this issue as well, client has about 8 tabs in one particular menu area. Not really wanting to write custom css for the admin area. composer.json is based around "silverstripe/recipe-cms": "^4.4.4"

@kinglozzer
Copy link
Member

Fixed in silverstripe/silverstripe-admin#906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants