Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2009-05-18] Enforce File/Image->can*() permissions in FileIframeField and ImageField #717

Closed
silverstripe-issues opened this issue May 13, 2013 · 2 comments
Assignees

Comments

@silverstripe-issues
Copy link

created by: @chillu (ischommer)
assigned to: @chillu (ischommer)
created at: 2009-05-18
original ticket: http://open.silverstripe.org/ticket/4084


Currently, these permissions are only enforced for folders in AssetAdmin, not for files in the popup.

Enforce this in the form display on FileIframeField and ImageField, e.g. by removing the "delete" button.

Also check the permissions before executing save() or delete() on the fields.

One problem is that File->canEdit() currently checks for CMS_ACCESS_AssetAdmin permissions, making the field unuseable for website users without CMS access. We might want to add a strict check for a new FILE_EDIT permission, that kicks in if defined, but falls back to CMS_ACCESS_AssetAdmin otherwise.

@ghost ghost assigned chillu May 13, 2013
@silverstripe-issues
Copy link
Author

comment by: @sminnee (sminnee)
created at: 2012-04-11


This is still an issue.

@simonwelsh simonwelsh added the 3.0 label Mar 16, 2014
@sminnee sminnee removed the 3.0 label Jul 21, 2015
@sminnee
Copy link
Member

sminnee commented May 17, 2017

these fields don't exist in 4

@sminnee sminnee closed this as completed May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants