Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSS feed for pre-SS4 comments doesn't work for blog posts #291

Open
matt-in-a-hat opened this issue Jul 8, 2019 · 1 comment
Open

RSS feed for pre-SS4 comments doesn't work for blog posts #291

matt-in-a-hat opened this issue Jul 8, 2019 · 1 comment
Labels
affects/v4 complexity/low impact/low type/bug

Comments

@matt-in-a-hat
Copy link

In SS3 it seems that the BaseClass for comments on a BlogPost used to get set to "SiteTree" instead of "BlogPost". Due to the migration task and #270 it works for new comments, which are saved with "SilverStripe\Blog\Model\BlogPost" but all existing comments just get changed to "SilverStripe\CMS\Model\SiteTree", and a URL like "/comments/rss/SilverStripe-Blog-Model-BlogPost/20" will not load the old ones.

Upgraded from
silverstripe/comments 2.1.7 e557e51
silverstripe/blog 2.5.2 0a823561

To
silverstripe/comments 3.1.6 f5c7024
silverstripe/blog 3.2.4 23f05ac2
@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Jul 9, 2019

Sounds like something we'll need to add to the migration script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/low type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matt-in-a-hat @ScopeyNZ @emteknetnz