Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SQLite module class namespaces, add to Travis matrix #161

Closed
robbieaverill opened this issue Nov 15, 2017 · 2 comments · Fixed by #184
Closed

Update SQLite module class namespaces, add to Travis matrix #161

robbieaverill opened this issue Nov 15, 2017 · 2 comments · Fixed by #184
Labels
affects/v4 complexity/medium impact/medium type/bug
Milestone
3.0.0

Comments

@robbieaverill
Copy link
Contributor

See comment: #141 (comment)

If we support SQLite in this module it would be good to add it to the Travis build matrix once we know it's working. It's not part of the SS3 version's configuration at this point.

See related: #160
@robbieaverill robbieaverill added this to the 3.0.0 milestone Nov 15, 2017
@robbieaverill robbieaverill self-assigned this Dec 1, 2017
@robbieaverill robbieaverill removed this from the 3.0.0 milestone Dec 4, 2017
@robbieaverill
Copy link
Contributor Author

robbieaverill commented Dec 4, 2017 •
edited
Loading

I'm going to add the namespaces but not add it to the Travis configuration, but the tests run for me locally which will be good for devs who want to use SQLite for faster testing.

@robbieaverill robbieaverill added this to the 3.0.0 milestone Dec 4, 2017
@robbieaverill robbieaverill mentioned this issue Dec 4, 2017
Merged
@robbieaverill
Copy link
Contributor Author

PR at #184

@robbieaverill robbieaverill removed their assignment Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/medium impact/medium type/bug
Projects
None yet
Milestone
3.0.0
1 participant
@robbieaverill