Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused SapphireTest::is_running_test check and any other references to it #163

Closed
robbieaverill opened this issue Nov 15, 2017 · 2 comments

Comments

@robbieaverill
Copy link
Contributor

The test suite at the moment is passing without throwing this exception: #141 (comment)

The fact that it's not being executed at the moment is not having an adverse effect on the test suite, so we should just remove this instead.

Also check for other references to is_running_test in the code and remove as necessary.

@raissanorth
Copy link
Contributor

raissanorth commented Nov 30, 2017

SapphireTest::is_running_test is not referenced anywhere else. See b448bfc

@robbieaverill
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants