Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite rule in base htaccess is missing [L] #241

Open
madmatt opened this issue Oct 28, 2018 · 0 comments
Open

Rewrite rule in base htaccess is missing [L] #241

madmatt opened this issue Oct 28, 2018 · 0 comments

Comments

@madmatt
Copy link
Member

madmatt commented Oct 28, 2018

The rewrite rule in the base .htaccess file (used when the public webroot exists but isn't the actual web root) lacks the [L] identifier, which I think we probably want in general to prevent infinite redirect loops. We just came across this in a client project that wasn't upgraded fully by the upgrader tool - it wrote the new RewriteRules to the project-root .htaccess file, but because the [L] flag wasn't set the original SS3 RewriteRule .* framework/main.php rule was overriding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants