Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Lumberjack triggers "newNode is not defined" js error #81

Open
cwchong opened this issue Apr 28, 2018 · 3 comments
Open

Nested Lumberjack triggers "newNode is not defined" js error #81

cwchong opened this issue Apr 28, 2018 · 3 comments

Comments

@cwchong
Copy link

cwchong commented Apr 28, 2018

SS4.1

Consider a situation where the parent page P has "lumberjacked" child pages C, which in turn also have "lumberjacked" grandchild pages G.
A grandchild page G when edited, cannot be rendered in the Sitetree navigation, because its parent C node is hidden in the navigation.

I believe that is the cause of the js error.

@robbieaverill
Copy link

So I guess we always need to show the selected page C when you're editing its children (G), regardless of whether the pages are set to be hidden via lumberjack in the SiteTree - would that make sense?

@cwchong
Copy link
Author

cwchong commented Apr 30, 2018

@robbieaverill yes that would make sense, and to generalise it should be, when editing a selected page G, all its ancestors should be unhidden in the sitetree

@NightJar
Copy link

Sounds a bit like the search filter funcitonality on the SiteTree structure itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants