Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to reset recovery codes #35

Closed
brynwhyman opened this issue Mar 17, 2019 · 5 comments
Closed

Ability to reset recovery codes #35

brynwhyman opened this issue Mar 17, 2019 · 5 comments

Comments

@brynwhyman
Copy link

brynwhyman commented Mar 17, 2019

As a CMS user with a registered MFA method, I want the ability to reset my recovery codes, so that if I loose them or if they are compromised I can access a new and secure set.

Backend work implemented in #4

ACs

  • Invokes the new modal, implemented in MFA in the CMS (create the modal) #46
  • There is the ability to reset recovery codes through the CMS member security form via a 'Reset recovery codes' action.
  • Selecting the 'Reset recovery codes' action presents a warning dialog to reset the codes.
  • Recovery codes can only be reset by the member which they are associated to.
  • On reset, the new recovery codes are displayed using the components created for the registration screen in Add back up code method - registration frontend #13
  • There is a button to download the codes using JavaScript.
  • There is a button to copy the codes to the clipboard.

Designs

@robbieaverill
Copy link
Contributor

robbieaverill commented Apr 23, 2019

We will need to add another audit hook for resetting backup codes when we do this. There's already one for registering backup codes as a method - we could either treat this as any other method (as it currently is) and log removal and registration of methods generally, or make a specific entry for backup codes when they are reset. You may want to know which user initiated the reset, but that could be the same for removing and registering any method - resetting backup codes is the only option that admins can perform for other users AFAIK, so might need its own hook. Anyway, keep in mind when doing this ticket.

#24

@newleeland
Copy link

resetting backup codes is the only option that admins can perform for other users AFAIK, so might need its own hook. Anyway, keep in mind when doing this ticket.

Is a new functionality we are allowing admins to do? Just thinking, by allowing admins to reset the recovery codes, ultimately gives them access reset account passwords.

@brynwhyman
Copy link
Author

resetting backup codes is the only option that admins can perform for other users AFAIK, so might need its own hook. Anyway, keep in mind when doing this ticket.

That's not something that's been captured as a requirement before. I wouldn't expect this issue to address that either. To be clear, this issue already has the following AC:

Recovery codes can only be reset by the member which they are associated to.

@brynwhyman
Copy link
Author

This work should be covered in the mammoth #85. @ScopeyNZ can confirm when it's been merged. Have a read of the ACs now to check you've covered everything.

@brynwhyman brynwhyman modified the milestones: Sprint 35, Sprint 36 May 28, 2019
@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Jun 4, 2019

Covered in #128

@ScopeyNZ ScopeyNZ closed this as completed Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants