Update README.md and images #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Attribution section for used icons in folder images/.
Optimized for smaller file size (reduction 75%) with same results
|
@hdpero, thanks for your PR! By analyzing the blame information on this pull request, I identified @candidasa to be a potential reviewer |
added 3 commits
August 12, 2016 01:36
* don't inline style attributes , use class attributes instead * don't add px in height and width attributes on <img> * in html5 <img> tag doesn't need to be closed
…js changes * created two css version - dev & prod (.min.css) * .min.css version has only needed and used selectors
|
Seems like a decent improvement to me |
|
@dhensby thanks! there are also a few visual improvements todo , so will probably make an another pull req. |
|
great, please do |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README.md with Attribution for used icons in folder images/ , in adition to that is second commit with optimization of said icons. Now those icons are 75% smaller in size with no noticable visual changes.