Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop triggering USER_ERRORs when no user logged in #5

Closed
dhensby opened this issue Sep 13, 2016 · 1 comment
Closed

Stop triggering USER_ERRORs when no user logged in #5

dhensby opened this issue Sep 13, 2016 · 1 comment

Comments

@dhensby
Copy link
Contributor

dhensby commented Sep 13, 2016

Instead of triggering user errors when no user is logged in and tries to access the editing controller, better to just return a permissions failure and catch this nicely in the CMS (display the authentication modal).
@3Dgoo 3Dgoo mentioned this issue Feb 12, 2018
Merged
@3Dgoo
Copy link
Contributor

3Dgoo commented Mar 1, 2018

This issue should now be fixed by the changes in #13

@dhensby dhensby closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhensby @3Dgoo