Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Add subsites integration #175

Closed
sabina-talipova opened this issue Oct 13, 2023 · 1 comment
Closed

TODO: Add subsites integration #175

sabina-talipova opened this issue Oct 13, 2023 · 1 comment

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 13, 2023

Description

There have been numerous discussions regarding Subsites integration, but there are not any PR indicating that this integration has been completed.
See: #70

If we integrate Subsites, we should set Subsite::disable_subsite_filter to true inStaticCacheFullBuildJob::getAllLivePageURLs().

@GuySartorelli
Copy link
Member

Gonna close this since there's no other open issues related to subsites integration - Either it's working, or it's not and nobody really cares.

There's an extension hook right in that spot anyway, so arguably it would be better for a 3rd party module (or subsites itself) to implement an extension to disable the subsite filter at that point, rather than having this module be coupled to subsites.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants