Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataDifferencer::getObjectDisplay should use CMSThumbnail to limit max size of images in diffs #414

Open
sabina-talipova opened this issue Oct 9, 2023 · 0 comments

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 9, 2023

Description

Investigate the possibility of using the Image::CMSThumbnail method instead of Image::getTag.
"Use CMSThumbnail instead to limit max size, blocked by DataDifferencerTest and GC not playing nice with mocked images".
See

protected function getObjectDisplay($object = null)
{
if (!$object || !$object->isInDB()) {
return '';
}
// Use image tag
// TODO Use CMSThumbnail instead to limit max size, blocked by DataDifferencerTest and GC
// not playing nice with mocked images
if ($object instanceof Image) {
return $object->getTag();
}
// Format title
return $object->obj('Title')->forTemplate();
}

@sabina-talipova sabina-talipova changed the title TODO: Use CMSThumbnail instead to limit max size TODO: DataDifferencer::getObjectDisplay should use CMSThumbnail instead to limit max size Oct 10, 2023
@GuySartorelli GuySartorelli changed the title TODO: DataDifferencer::getObjectDisplay should use CMSThumbnail instead to limit max size DataDifferencer::getObjectDisplay should use CMSThumbnail to limit max size of images in diffs Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant