Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage: Check for the content of the original version in the request result #90

Open
sabina-talipova opened this issue Oct 9, 2023 · 0 comments

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 9, 2023

Description

VersionFeedFunctionalTest::testChangesActionContainsChangesForCurrentPageOnly test should check additionally for the content of the original version in the request result.
See

public function testChangesActionContainsChangesForCurrentPageOnly()
{
$page1 = $this->createPageWithChanges(['Title' => 'Page1']);
$page2 = $this->createPageWithChanges(['Title' => 'Page2']);
$response = $this->get($page1->RelativeLink('changes'));
$xml = simplexml_load_string($response->getBody());
$titles = array_map(function ($item) {
return (string)$item->title;
}, $xml->xpath('//item'));
// TODO Unclear if this should contain the original version
$this->assertContains('Changed: Page1', $titles);
$this->assertNotContains('Changed: Page2', $titles);
$response = $this->get($page2->RelativeLink('changes'));
$xml = simplexml_load_string($response->getBody());
$titles = array_map(function ($item) {
return (string)$item->title;
}, $xml->xpath('//item'));
// TODO Unclear if this should contain the original version
$this->assertNotContains('Changed: Page1', $titles);
$this->assertContains('Changed: Page2', $titles);
}

@sabina-talipova sabina-talipova changed the title TODO: Unclear if this should contain the original version TODO: testChangesActionContainsChangesForCurrentPageOnly() Add to the test an additional check for the content of the original version in the request result Oct 10, 2023
@sabina-talipova sabina-talipova changed the title TODO: testChangesActionContainsChangesForCurrentPageOnly() Add to the test an additional check for the content of the original version in the request result TODO: VersionFeedFunctionalTest. Add to the test an additional check for the content of the original version in the request result Oct 10, 2023
@GuySartorelli GuySartorelli changed the title TODO: VersionFeedFunctionalTest. Add to the test an additional check for the content of the original version in the request result Test coverage: Check for the content of the original version in the request result Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant