SelectAll and DeselectAll issues

[brooklynb7]

I found that if I want to selectAll/deselectAll via program I must show the list items first otherwise these two events don't work.

And I digged into the code and I found that at line.860 and line.865, the selector for these two events is like this:

this.$lis.not('.divider').not('.disabled').filter('.selected').filter(':visible').find('a').click();

And the selector .filter(':visible') make this issue I guess. I commented this selector and then they work well.

So why is .filter(':visible') added here? Thanks

[t0xicCode]

It was added so that clicking "Select All" after having done a search in the option would only select the visible options. I'll look into an alternative implementation.

[caseyjhol]

Perhaps .not('.hide') instead of .filter(':visible')

[t0xicCode]

Yeah, that would work.

[caseyjhol]

Just tested and it looks like that fixes it. .filter(':visible') is a remnant from before we used the .hide class on hidden elements.

[t0xicCode]

Feel like committing the fix?

[caseyjhol]

Swamped with another project right now, but should be able to get to this next week.

[marviljoy]

Please find a solution for this.. Very urgent

[ThCC]

+1