Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1.0] Debian build and how to skip ascent downloading ? #4115

Closed
picca opened this issue Apr 21, 2024 · 4 comments
Closed

[2.1.0] Debian build and how to skip ascent downloading ? #4115

picca opened this issue Apr 21, 2024 · 4 comments

Comments

@picca
Copy link
Contributor

picca commented Apr 21, 2024

Hello, while preparing the Debian package of silx.

I have this failure.
'''
Downloading file 'ascent.dat' from 'https://raw.githubusercontent.com/scipy/dataset-ascent/main/ascent.dat' to '/builds/science-team/silx/debian/output/source_dir/.pybuild/cpython3_3.11_silx/.cache/scipy-data'.
'''

the full log is here.

https://salsa.debian.org/science-team/silx/-/jobs/5622288

is it possible to skip these test easily ?

For security reason, it is not allow to have network connetion during a Debian build.

thanks for your advices.

Fred

@t20100
Copy link
Member

t20100 commented May 2, 2024

Hi,

Here are a couple of options I can come up with:

  • If scipy is not installed, those tests will be skipped (but other tests will also be skipped). Is it easy to do so in the packaging config?

  • Otherwise, is it possible to copy the ascent.dat in the packaging repo and then copy it to /builds/science-team/silx/debian/output/source_dir/.pybuild/cpython3_3.11_silx/.cache/scipy-data/? The pooch package used by scipy would then find it.

  • I don't know what is the usual Debian way, but the scipy packaging could also embed the data files: The cache folder can be changed by patching the following line in scipy: https://github.com/scipy/scipy/blob/c0fa9e36168c24ce6772e054653c82c73e083d56/scipy/datasets/_fetchers.py#L14
    That would be a generic way to fix it.

  • Finally, we could also embed the ascent.dat file in silx (it's "public domain"), but that would be for another release.

Let me know what you think of those approaches.

@picca
Copy link
Contributor Author

picca commented May 2, 2024 via email

@t20100
Copy link
Member

t20100 commented May 2, 2024

  • Finally, we could also embed the ascent.dat file in silx (it's "public
    domain"), but that would be for another release.

I think that it is a bad idea :)). :p

Fully agreed! That was my last option ;)

once again. Thanks a lot.

You're welcome, and thanks a lot for all the packaging effort!

@t20100
Copy link
Member

t20100 commented Jul 8, 2024

I'm closing this issue since it looks to have been fixed in the Debian packaging project: https://salsa.debian.org/science-team/silx/-/commit/31d61a4b6a375f545472c5e2580f6b0889b73ba7

Please reopen if needed

@t20100 t20100 closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants