Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch alignment & tracking upstream? #62

Closed
sunnygleason opened this issue Oct 7, 2019 · 3 comments
Closed

arch alignment & tracking upstream? #62

sunnygleason opened this issue Oct 7, 2019 · 3 comments

Comments

@sunnygleason
Copy link
Member

I started on this pull request to get us closer to upstream structure, I think we're in a good place to pick it up again maybe?

#46

@Licenser, what would you think about this idea:

  • in the README/Cargo.toml description/etc, we add some description of currently tracking simdjson vX.Y.Z
  • we finish that arch alignment to get the raw (current) codebase close in a majority sense (of course except for the necessary rust-specific enhancements)
  • we genericise/template-enable the code that was made more similar by arch alignment (reducing the size of platform-specific modules)
  • this should get the core features very close to the corresponding upstream version 🎉

Very interested in your thoughts! 🥂

@Licenser
Copy link
Member

Licenser commented Oct 7, 2019

👍 sounds good, the only thing with #46 was that we need to make sure we don't degrade performance.

@sunnygleason
Copy link
Member Author

💯

@sunnygleason
Copy link
Member Author

implemented by #80, #81, merged with #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants