Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error masks should probably not be needlessly converted to booleans #16

Closed
lemire opened this issue Aug 29, 2018 · 1 comment
Closed

Error masks should probably not be needlessly converted to booleans #16

lemire opened this issue Aug 29, 2018 · 1 comment

Comments

@lemire
Copy link
Member

lemire commented Aug 29, 2018

There are many checks to see if the error masks are non-zero, and then work on booleans. I am guessing that this is not generally a problem due to branch predictions, but it seems unwarranted.
@lemire
Copy link
Member Author

lemire commented Dec 1, 2018

I think that this is no longer relevant.

@lemire lemire closed this as completed Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lemire