Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License of ConvertUTF.cpp and ConvertUTF.h #170

Closed
bkmgit opened this issue Sep 18, 2022 · 1 comment
Closed

License of ConvertUTF.cpp and ConvertUTF.h #170

bkmgit opened this issue Sep 18, 2022 · 1 comment

Comments

@bkmgit
Copy link
Contributor

bkmgit commented Sep 18, 2022

The files ConvertUTF.h and ConvertUTF.cpp seem to be under non free licenses. The LLVM project has updated them, see here, with ConvertUTF.h from breakpad and ConvertUTF.cc also from breakpad. As indicated at AmokHuginnsson/replxx#12, they can also be replaced by https://github.com/nemtrif/utfcpp

@lemire
Copy link
Member

lemire commented Oct 27, 2022

These files are not part of the simdutf library. They are part of a benchmark routine which relies on other libraries. We state:

We include a few competitive solutions under the benchmarks/competition directory. 
They are provided for research purposes only.

The link you offer states that...

The code does not need to be replaced for license reasons. The files were
relicensed to a proper license by Unicode.org some 15 years ago, so we
fixed this issue for llvm by applying the "new" license terms to our copy.

We would, of course, invite the addition of utfcpp to our benchmarks. Pull request invited.

@lemire lemire closed this as completed Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants