Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency to libICU should be optional #84

Closed
WojciechMula opened this issue Nov 29, 2021 · 5 comments
Closed

Dependency to libICU should be optional #84

WojciechMula opened this issue Nov 29, 2021 · 5 comments

Comments

@WojciechMula
Copy link
Collaborator

Didn't dig into the benchmarks' details, but I believe me may conditionally compile parts requiring ICU.

@lemire
Copy link
Member

lemire commented Nov 29, 2021

@WojciechMula I think that it is currently optional in the sense that it should still build even if ICU is missing.

Of course, it would be nicer to build it as a CMake dependency, say.

(Be mindful that we want to be as portable as possible.)

@lemire
Copy link
Member

lemire commented Nov 29, 2021

Also, of course, it is only required for benchmarking.

@WojciechMula
Copy link
Collaborator Author

Unfortunately, the lib does not build if ICU is missing. I'll look at this in my spare time.

@lemire
Copy link
Member

lemire commented Nov 29, 2021

That's a bug because we do have the checks in place...

#if ICU_AVAILABLE

@WojciechMula
Copy link
Collaborator Author

Sorry, it was my mistake. Cmake reported an error, but I didn't notice that I pasted some garbage into the cmd line. The actual error wasn't related to ICU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants