-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency to libICU should be optional #84
Comments
@WojciechMula I think that it is currently optional in the sense that it should still build even if ICU is missing. Of course, it would be nicer to build it as a CMake dependency, say. (Be mindful that we want to be as portable as possible.) |
Also, of course, it is only required for benchmarking. |
Unfortunately, the lib does not build if ICU is missing. I'll look at this in my spare time. |
That's a bug because we do have the checks in place... simdutf/benchmarks/src/benchmark.h Line 58 in 98915f8
|
Sorry, it was my mistake. Cmake reported an error, but I didn't notice that I pasted some garbage into the cmd line. The actual error wasn't related to ICU. |
Didn't dig into the benchmarks' details, but I believe me may conditionally compile parts requiring ICU.
The text was updated successfully, but these errors were encountered: