Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] CategoryBookSelector & tag selector #313

Open
simian114 opened this issue Jan 6, 2024 · 0 comments
Open

[Refactor] CategoryBookSelector & tag selector #313

simian114 opened this issue Jan 6, 2024 · 0 comments
Assignees
Labels
refactoring refactoring

Comments

@simian114
Copy link
Owner

as-is

  • categoryBookSelector가 suburl selector로만 사용됨
  • TagSelector가 post list도 같이 관리하고 있음.

to-be

  • categoryBookSelector는 타입에 따라 sub url 또는 searchParams 으로 사용될 수 있게 수정
    • ?category=xxx 로 변경
    • multi select 가능
  • TagSelector가 post list를 관리하는게 아니라, tag Selector는 아주 단순하게 클릭 시 search params만 변경
  • post list를 감싸는 client component에서 search params을 보고 post list를 필터링 하도록 수정
@simian114 simian114 added the refactoring refactoring label Jan 6, 2024
@simian114 simian114 self-assigned this Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring refactoring
Projects
None yet
Development

No branches or pull requests

1 participant