Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability: search box & command palette #1

Closed
syu-id opened this issue Dec 18, 2019 · 3 comments
Closed

Readability: search box & command palette #1

syu-id opened this issue Dec 18, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@syu-id
Copy link

syu-id commented Dec 18, 2019

Thank you for creating this beautiful theme!
I encountered two readability issues:

Search box

The search box has transparent background; case and regex toggles are not shown.

Default

Tailwind

Command palette

Black-on-purple text is a bit difficult to read.

Default

Tailwind
@simicd
Copy link
Owner

simicd commented Dec 18, 2019

Thank you @RongMu, I'm very glad to hear you like the theme!
I appreciate your feedback - looked at both issues you reported and made adjustments to the theme. Below a proposal - if you are fine with this I will publish it to npm.

  • Search box:
    image

  • Command palette:
    image

@simicd simicd self-assigned this Dec 18, 2019
@simicd simicd added the enhancement New feature or request label Dec 18, 2019
@syu-id
Copy link
Author

syu-id commented Dec 19, 2019

Thank you for the response.
The changes look great! I really appreciate your work.

@simicd simicd mentioned this issue Dec 19, 2019
@simicd
Copy link
Owner

simicd commented Dec 19, 2019

Thank you - I merged the changes into master and published v0.3.1 to npm. Have a great rest of the week!

@simicd simicd closed this as completed Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants