-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple user support. #24
Comments
Would happily take this task on to get me familiar with the codebase. Feel free to assign me |
I think this should go into a middleware, and create a route group in
This one can be done by adding a switch option to the admin api settings that can disable Jellyfin. Also, functions in This controller will be renamed and it has unused functions which also will be deleted soon.
This one is basically rewriting We well need an Anki host option for users. User settings are not yet implemented in linguacafe, I think we can just use localhost, and I'll write the user settings page. There was also a problem with sending http requests from javascript to an external URL. I had this problem a long time ago, I think it's an easy fix, it just needs an HTML meta tag, but I don't remember exactly. It is actually seems surprisingly easy to enable this feature. Everything is written in a way that should work with multiple users, I just never ever tested it, so I disabled it before publishing the repo. Thank you so much for working on it! :) |
I've updated the contributing.md file. |
@jacovanc |
I'm going to assume the answer to this is "no", but just double checking. Is it possible to add a second user to this? I see the "add user" button on the admin account, but it's greyed-out. |
Currently no. |
Finally got around to starting this, hopefully have a pull request sometime this week (or early next week) |
@jacovanc I will probably have a large merge into dev in the next two days from the features/language-install branch. I try to avoid merge and PR conflicts so I don't mess up other people's work, I'm not sure yet how to handle working with multiple people. So far we had no feature branches, and only got small PR-s. I'll try to think it through and figure things out. |
@jacovanc I've added a new task related to multi user support. I think I will have time to work on this feature sometime in the summer as well if it's not finished until then. |
I wrote everything in LinguaCafe with multiple user support in mind and it probably already works. Other than the admin page all code was written in a way that users can only interact with their own data, but it hasn't been tested yet.
These tasks should be done in order to allow this feature:
The text was updated successfully, but these errors were encountered: