Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "base_word" to "lemma". #99

Open
simjanos-dev opened this issue Jan 31, 2024 · 2 comments
Open

Rename "base_word" to "lemma". #99

simjanos-dev opened this issue Jan 31, 2024 · 2 comments
Labels
code changes Code changes that do not have a functional impact, but improve it in some way.

Comments

@simjanos-dev
Copy link
Owner

In the code lemmas are named "base_word". It should be replaced with "lemma". Also "base_word_reading" with "lemma_reading".

The encountered_words database table also has both "base_word" and "lemma" columns for no reason. Only the lemma should be kept.
@simjanos-dev simjanos-dev added the code changes Code changes that do not have a functional impact, but improve it in some way. label Jan 31, 2024
@simjanos-dev simjanos-dev mentioned this issue Feb 7, 2024
Closed
17 tasks
@GrimPixel
Copy link

You may try VSCodium, which can find and replace all occurrences of some text in a directory.

@simjanos-dev
Copy link
Owner Author

I use VSCode, I know about that. I am kind of paranoid, I will still going to look through each change afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code changes Code changes that do not have a functional impact, but improve it in some way.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GrimPixel @simjanos-dev