Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shavuos in Elul? #24

Closed
Ishayahu opened this issue Aug 24, 2022 · 3 comments
Closed

Shavuos in Elul? #24

Ishayahu opened this issue Aug 24, 2022 · 3 comments

Comments

@Ishayahu
Copy link

Ishayahu commented Aug 24, 2022

today

HebrewDate(5782, 5, 27)

(today+10)

HebrewDate(5782, 6, 7)

(today+10).month_name()

'Elul'

(today+10).holiday()

'Shavuos'

@Ishayahu
Copy link
Author

your error is in utils.py at line 256:
elif month == 3 and day == 6 or (not israel and day == 7)
for month=6 and day=7 it results in
False and False or True == True
it should be
elif month == 3 and (day == 6 or (not israel and day == 7))
then it will be
False and (False or True) = False and True = False

@simlist
Copy link
Owner

simlist commented Aug 24, 2022

Thank you! I'll try to have a fix out asap.

@simlist
Copy link
Owner

simlist commented Aug 24, 2022

Fixed in v2.0.1. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants