Add proper timezone support #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for taking a while to get to this. It looks pretty reasonable; I'll have time to play around with it this weekend. |
|
Look good! I added some minor changes. Let me know what you think; if they're cool I'll go ahead and merge. |
pieterdd
commented
Oct 27, 2018
pieterdd
commented
Oct 27, 2018
|
Rebasing to remove the commit and its revert because they cancel each other out. Previous HEAD of this branch: 25205fd |
pieterdd
force-pushed
the
normalize-time-zone
branch
2 times, most recently
from
6134f65
to
8599706
Compare
- When passing in a datetime object with a timezone, adjust system clock correctly. - tz_offset is still supported when passing in a string as timestamp. - When passing in a datetime with timezone info, tz_offset is unsupported.
pieterdd
force-pushed
the
normalize-time-zone
branch
from
8599706
to
236e087
Compare
|
This branch is good to go as far as I'm concerned, assuming the build passes. An hour after I last pushed a commit, the Travis build was still queued so I don't know yet. |
|
Thanks! I'll cut a release for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correctly.
unsupported.