-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash report #147
Comments
@Blankwonder Thanks for reporting this! Based on the stack trace it looks like the issue may have been introduced in version 0.2.1 of the framework. I'll have a look at it right away. Based on the stack trace and the theory that this issue was introduced in 0.2.1, it should only occur when inputting marked text, such as Korean characters. Does your app happen to be popular in regions where marked text is common? Knowing whether that's the case or not may help me verify if the issue could be related to the recent changes to Runestone. |
@simonbs It's correct. My users are likely to input Chinese characters. |
@Blankwonder Thanks for the prompt reply! That's very helpful. I'll have a look at what's going on. |
I've been unable to reproduce this issue but if the assumption that the issue was introduced in 0.2.1 is correct, then I think it'll be resolved by the changes in #149. I'm thinking that the with the changes in 0.2.1, Runestone would sometimes end in a state where the selected range was invalid. That should no longer be possible in #149. I'd like to stress that I take this issue very seriously. I've spent a lot of time ensuring proper support for inputting marked text but the APIs to support this are awful and likely buggy as outlined in #129. Knowing very little about how marked text is supposed to work, as I have very little experience with it, I think the current implementation works as expected but of course it shouldn't cause the app to crash. That needs to be fixed ASAP. I'd greatly appreciate if you'll take the current main branch for a spin, and possibly adopt it in your app, possibly in a future TestFlight build, and let me know if the problem persists. Unfortunately, I don't have a large user base inputting Chinese characters so I struggle to get the proper data and stress test this as long as I'm unable to reproduce the issue. |
Just released a TestFlight build, which was built with the Runestone main branch. I will get back to you a couple of days later. |
@Blankwonder Thanks you so much! Looking forward to hear from you. |
Just received a crash report from the latest build. (Xcode is so buggy. Please confirm whether I built it with the correct branch.)
|
Thanks for following up. I hoped to look into this today but ended up looking at another issue instead. I hope to get around to it tomorrow. |
Still planning to look into this issue soon.
I'm not sure I can do that from your stack trace. To be sure that you're building with the correct version of Runestone, you may want to ask Swift Package Manager to pin against this commit, reset your package cache, and then update the Runestone package in Xcode. |
@Blankwonder Long shot but here goes: Can we get more information on how to reproduce this, possibly from a support ticket you might have going with your one of your users? I'm hoping this bug is simple to fix once it can be reproduced but I struggle to do so. |
Sorry. I haven't received any related tickets from users. But I just tried randomly typing Chinese and got another crash after a double tap. 😂
|
@Blankwonder Thanks for trying to reproduce this. I'm unsure if the last stack trace you've posted is related to the other stack traces. The two first stack traces both include Since the third stack trace includes references to UIEditMenuInteraction, I assume you're testing on iOS 16. Do you happen to have any data on which devices the other stack traces are coming from? Is it iPhones or iPads? And which version of iOS/iPadOS are they running? I'm asking all these (possibly) annoying questions because I've been trying to reproduce the issue for quite a while but I haven't seen it once. I'd like to understand scenarios it's happening in better. |
Oh, sorry for not mentioning it early. I checked the crash collect system. 21 crash reports, and they are all from iOS 16. And all from iPhone |
@Blankwonder I was able to reproduce the issue you describe where double tapping to select text may cause a crash. This seemed to only happen on iOS 16. It should be fixed in #157, which was just merged into development. After having looked into this, I would no longer be surprised if the root cause for the issue your users are seeing is the same as the one causing a crash when double tapping to select text. Would you mind making a build of your app with the most recent changes on the main branch? |
@simonbs That's great. I will release a test build a few hours later. |
Good news. I haven't received any new crashes in the last 48 hours. |
@Blankwonder That's great! Last time you uploaded a new build the issues seemed to arrive fairly quickly. I'll close the issue and consider the crash fixed but please don't hesitate to open an issue again if you still see the crashes. You can just open one referring to this issue if that happens. Thanks a lot for reporting the issue, for testing the changes in your app, and for providing feedback along the way 🙌 |
Hi
I received several crash reports after using Runestone as the text editor within my app. But I'm not sure how to reproduce it. You may want to take a look.
Thanks for your work, by the way.
(Version 0.2.1)
The text was updated successfully, but these errors were encountered: