Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'deny == false' should be evaluated first before calling allow_access() #7

Open
kd-labs opened this issue Apr 3, 2023 · 0 comments

Comments

@kd-labs
Copy link

kd-labs commented Apr 3, 2023

First 'deny' is evaluated. Then when evaluating 'allow' we can use the value of deny already computed as an early escape clause so as to avoid calling allow_access() when deny is false

Therefore, 'deny==false' should be moved to line 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant