Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Background color with dark code theme isn't dark #103

Closed
mauricedb opened this issue Nov 16, 2021 · 2 comments
Closed

bug: Background color with dark code theme isn't dark #103

mauricedb opened this issue Nov 16, 2021 · 2 comments
Labels

Comments

@mauricedb
Copy link

Context:

  • version (md-to-pdf -v): 5.0.0
  • platform (Unix, macOS, Windows): Windows
  • node version: v14.18.0

Describe the bug:

I am trying to convert a Markdown document with TypeScript code using the GitHub Dark highlight style using the command md-to-pdf .\doc.md --highlight-style=github-dark. However the background for all code remains light. The code text colors are updated making the text almost unreadable.

image

When rendering to HTML I noticed the line background-color: #f8f8f8 !important; here that seems to overrule the background color from github-dark.css.

With !important

image

Without !important

image

@mauricedb mauricedb added the bug label Nov 16, 2021
@mauricedb mauricedb changed the title bug: bug: Background color with dark code theme isn't dark Nov 17, 2021
@simonhaenisch
Copy link
Owner

Hey thanks for the bug report, i'll get this fixed today.

@mauricedb
Copy link
Author

Thanks for the fast fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants