Support fixed and responsive layouts #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andreasschacht @lolmaus some bigger changes of the component API / feature set 👆 Feel free to chime in if you have thoughts! |
This accumulates a few (breaking) changes: * will add the CSS for responsive (fluid) image layout (the default) * when passing `@width` and/or `@height` arguments, it will opt into fixed layout (closes #117) * in fixed layout, it will pick the (fallback) `src` attribute based on the fixed width, pick `srcset` sources for that given width and pixel densities of `1x` and `2x`, and `width` and `height` with the appropriate fixed values (if one is missing, it will be computed based on the image's aspect ratio) * in responsive layout, `width` and `height` attributes are rendered even though the *actual* size is responsive, to let the browser know the correct vertical size (even before the image has been loaded), to reduce [Cumulative Layout Shift](https://web.dev/cls/) (Closes #88) * some (breaking) related changes in the service's API, removing `getImageBySize()`, renaming `getImageDataBySize()` to `getImageMetaBySize()` and introducing `getImageMetaByWidth()`
simonihmig
force-pushed
the
image-layout
branch
from
ecd489a
to
a889521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accumulates a few (breaking) changes:
@widthand/or@heightarguments, it will opt into fixed layout (closes Add fixed size support #117)srcattribute based on the fixed width, picksrcsetsources for that given width and pixel densities of1xand2x, and renderwidthandheightattributes with the appropriate fixed values (if one is missing, it will be computed based on the image's aspect ratio)widthandheightattributes are rendered even though the actual size is responsive, to let the browser know the correct vertical size (even before the image has been loaded), to reduce Cumulative Layout Shift (Closes Set width/height attributes on <img> #88)getImageBySize(), renaminggetImageDataBySize()togetImageMetaBySize()and introducinggetImageMetaByWidth()