Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to recursively process sub directories of sourcePath #71

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

elgordino
Copy link
Contributor

Adds a recursive option that, when set, will traverse the directory structure looking for images to process.

Also adds a warning if a sourceDir includes a directory but recursive is not set.

@simonihmig
Copy link
Owner

simonihmig commented Aug 26, 2020

Looks good, thanks a lot @elgordino!
And sorry for the late responsive! This slipped through...

I wonder though if we really need the recursive option, or if we should rather always do a recursive walk? Like is there a use case where you have subfolders in your image folder, but don't want them to be processed?

@andreasschacht thoughts?

@simonihmig simonihmig merged commit 4db6f8d into simonihmig:master Jan 8, 2021
@simonihmig
Copy link
Owner

Sorry for keeping this in limbo for so long. Finally I have reserved some time to work on this addon, and cut a new release asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants