Skip to content
This repository has been archived by the owner on Dec 12, 2021. It is now read-only.

Potential refactoring #1

Closed
karianna opened this issue Dec 10, 2021 · 2 comments
Closed

Potential refactoring #1

karianna opened this issue Dec 10, 2021 · 2 comments

Comments

@karianna
Copy link

Hi @simonis - we had a go at refactoring your patch to have a little more SRP and try with resources and some naming clarifications.

It's hosted at https://github.com/karianna/Log4jPatch - please let me know if you'd want a PR for this (it does change the structure significantly).

FYI - we didn't spot any major issues, just some potentially leaky resources.

@simonis
Copy link
Owner

simonis commented Dec 10, 2021

Hi @karianna,

Thanks for trying this out and for your improvement suggestions. They look reasonable.

@karianna
Copy link
Author

Cool, will PR after I tidy some comments, thanks for teaching me some new things this weekend!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants