Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Testing: Modal Contact Form doesn't close after sending the form data #44

Closed
simonjvardy opened this issue Aug 20, 2020 · 0 comments · Fixed by #73
Closed

Unit Testing: Modal Contact Form doesn't close after sending the form data #44

simonjvardy opened this issue Aug 20, 2020 · 0 comments · Fixed by #73
Labels
bug Something isn't working enhancement New feature or request
Projects
Development

Comments

@simonjvardy
Copy link
Owner

Describe the bug
After entering data in all the required fields, the modal doesn't automatically close after clicking the submit button

To Reproduce
Steps to reproduce the behavior:

  1. Go to Home page
  2. Click on ''Contact Us Today' button
  3. Enter valid data into the required form fields in the modal
  4. Click 'Send'
  5. The data is sent but the modal remains open

Expected behavior
The modal window needs to close when the send button has been clicked

Screenshots
TBC

Desktop (please complete the following information):

  • OS: OS X El Capitan
  • Browser Firefox
  • Version 78.0.1esr (64-bit)

Additional context
Adding the attribute data-dismiss="modal" closes the modal when the 'Send' button is clicked but the form data is not submitted so not a viable solution.
@simonjvardy simonjvardy added bug Something isn't working enhancement New feature or request labels Aug 20, 2020
@simonjvardy simonjvardy added this to To do in Development via automation Aug 20, 2020
simonjvardy added a commit that referenced this issue Aug 30, 2020
@simonjvardy
Fix: Issue #37 + #44
721b544 
Fix issue #44 Modal contact form doesn't close after sending dara - send button now opens the confirmation page
Fix issue #37 Contact modal form submits data correctly but no confirmation to the user - send button now opens the confirmation page
@simonjvardy simonjvardy mentioned this issue Aug 30, 2020
Merged
@simonjvardy simonjvardy linked a pull request Aug 30, 2020 that will close this issue
Fix: Issue #37 + #44 modal contact form problems #73
Merged
Development automation moved this from To do to Done Aug 30, 2020
simonjvardy added a commit that referenced this issue Aug 30, 2020
@simonjvardy
Merge pull request #73 from simonjvardy/development
3a8180d 
Fix: Issue #37 + #44 modal contact form problems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
Development
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Issue #37 + #44 modal contact form problems simonjvardy/Aviation-Consultancy
1 participant
@simonjvardy