%shift pragma for lowest priority rules #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://gitlab.haskell.org/ghc/ghc/merge_requests/1867 is currently blocked on a release with this. |
|
The AppVeyor CI failure is unrelated to the patch and is fixed in #154 |
|
This looks like it's a user-facing feature addition to |
|
I'd be happy to merge this, but can we have documentation and a test please? |
I'm on it – setting up DocBook locally proved to be a bit of a challenge. Will push an update today. |
|
There's a test case and a section in the manual now. |
|
As someone who has taught |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHC Merge Request 1856 resolves shift/reduce conflicts in GHC by using the precedence machinery of
happy, marking certain rules as%prec shift.However, the downside of this approach is that it requires a listing of all lookahead tokens. With a dedicated pragma
%shift, we can avoid this.