Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor errors I detected #2

Open
eloimoliner opened this issue Mar 2, 2022 · 1 comment
Open

Some minor errors I detected #2

eloimoliner opened this issue Mar 2, 2022 · 1 comment

Comments

@eloimoliner
Copy link

eloimoliner commented Mar 2, 2022

Hi,
Thanks for your nice contribution!
I detected a couple of errors that maybe you would like to correct:
Here:

return VpSdeCos(sigma_min, sigma_max)

sigma_min and sigma_max are not required for the constructor of VpSdeCos. Same for the other SDEs.
And here:
t = (self.sde.t_max - self.sde.t_min) * t + self.sde_t.t_min

"self.sde_t" is not defined. Maybe it should be "self.sde"?

@simonrouard
Copy link
Owner

Hi @eloimoliner, indeed there is a typo, the first on should be 'return VpSdeCos()'.
The second one is 'self.sde' instead of 'self.sde_t'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants