Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table actions hook are order dependent, should not be #1123

Closed
simonw opened this issue Dec 3, 2020 · 1 comment
Closed

Table actions hook are order dependent, should not be #1123

simonw opened this issue Dec 3, 2020 · 1 comment
Labels

Comments

@simonw
Copy link
Owner

simonw commented Dec 3, 2020

Got this error: https://github.com/simonw/datasette/runs/1489770800

>       assert get_table_actions_links(response_2.text) == [
            {"label": "From async", "href": "/"},
            {"label": "Database: fixtures", "href": "/"},
            {"label": f"Table: {table_or_view}", "href": "/"},
        ]
E       AssertionError: assert [{'href': '/'...'From async'}] == [{'href': '/'...: facetable'}]
E         At index 0 diff: {'label': 'Database: fixtures', 'href': '/'} != {'label': 'From async', 'href': '/'}
E         Use -v to get the full diff
@simonw
Copy link
Owner Author

simonw commented Dec 3, 2020

Affected tests:

FAILED tests/test_plugins.py::test_hook_table_actions[facetable] - AssertionE...
FAILED tests/test_plugins.py::test_hook_table_actions[simple_view] - Assertio...

@simonw simonw closed this as completed in 13c960c Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant