-
-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share button for copying current URL #1241
Comments
This can definitely be done with a plugin. Adding to Datasette itself is an interesting idea. I think it's possible that many users these days no longer assume they can paste a URL from the browser address bar (if they ever understood that at all) because to many apps are SPAs with broken URLs. The shareable URLs are actually a key feature of Datasette - so maybe they should be highlighted in the default UI? I built a "copy to clipboard" feature for |
A "Share link" button would only be needed on the table page and the arbitrary query page I think - and maybe on the row page, especially as that page starts to grow more features in the future. |
Absolutely, that's why I thought my corner case with |
I really like the way the Share feature on Stack Overflow works: https://stackoverflow.com/questions/18934149/how-can-i-use-postgresqls-text-column-type-in-django |
One possible treatment: <style>
a.action-button {
display: inline-block;
border: 1.5px solid #666;
border-radius: 0.5em;
background-color: #ffffff;
color: #666;
padding: 0.1em 0.8em;
text-decoration: none;
margin-right: 0.3em;
font-size: 0.85em;
}
</style>
<p>
{% if query.sql and allow_execute_sql %}
<a class="action-button"
title="{{ query.sql }}"
href="{{ urls.database(database) }}?{{ {'sql': query.sql}|urlencode|safe }}{% if query.params %}&{{ query.params|urlencode|safe }}{% endif %}">
View and edit SQL
</a>
{% endif %}
<a href="#" class="action-button">Copy and share link</a>
</p> |
Something to think about, but I hate how long the url is when sharing a custom SQL query. Would it be possible to hash the query and state of a page instead so the url is more manageable? The mapping from hash to query would have to be stored in order to recover/lookup the page after sharing. It's not uncommon to have things like this currently:
I'm thinking a plugin like https://datasette.io/plugins/datasette-query-files, but could be created and managed from the UI (with the right permissions). |
I use datasette in an
iframe
inside another HTML file that contains other ways to represent my data (mostly leaflets maps built with R on summarized data), and the datasetteiframe
is a tab in that page.This particular use prevents users to access the full URLs of their datasette views and queries, which is a shame because the way datasette handles URLs to make every view or query easy to share is awesome. I know how to get the URL from the context menu of my browser, but I don't think many visitors would do it or even notice that datasette uses permalinks for pretty much every action they do. Would it be possible to add a "Share link" button to the interface, either in datasette itself or in a plugin?
The text was updated successfully, but these errors were encountered: