Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some links aren't properly URL encoded. #1261

Closed
brimstone opened this issue Mar 15, 2021 · 3 comments
Closed

Some links aren't properly URL encoded. #1261

brimstone opened this issue Mar 15, 2021 · 3 comments

Comments

@brimstone
Copy link

It seems like a percent sign in the query causes some links to end invalid.

The json and CSV links on this page don't behave like expected: https://honeypot-brimston3.vercel.app/honeypot?sql=select+time%2C+count%28time%29+as+count+from+%28select+strftime%28%22%25Y-%25m-%25d%22%2C+_etime%29+as+time+from+ssh+%29+group+by+time+order+by+time%3B

I can take a swing at trying to fix this, but my python isn't strong and I need a pointer at the right approach and files to change.

Thanks!

@simonw
Copy link
Owner

simonw commented Mar 20, 2021

This isn't a Datasette bug - it's a Vercel bug: simonw/datasette-publish-vercel#28

I'm looking at a fix for that now, so watch that issue for updates.

@simonw
Copy link
Owner

simonw commented Mar 20, 2021

That's fixed in this release of datasette-publish-vercel: https://github.com/simonw/datasette-publish-vercel/releases/tag/0.9.2

@brimstone
Copy link
Author

I can confirm 0.9.2 fixes the problem. Thanks for the fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants