Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-formatter javascript is not now working with CloudFlare rocketloader #1969

Open
fgregg opened this issue Dec 23, 2022 · 0 comments
Open

sql-formatter javascript is not now working with CloudFlare rocketloader #1969

fgregg opened this issue Dec 23, 2022 · 0 comments
Labels
bug help wanted javascript

Comments

@fgregg
Copy link
Contributor

fgregg commented Dec 23, 2022 •
edited

This is probably not a bug with datasette, but I thought you might want to know, @simonw.

I noticed today that my CloudFlare proxied datasette instance lost the "Format SQL" option. I'm pretty sure it was there last week.

In the CloudFlare settings, if I turn off Rocket Loader, I get the "Format SQL" option back.

Rocket Loader works by asynchronously loading the javascript, so maybe there was a recent change that doesn't play well with the asynch loading?

I'm up to date with e03aed0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted javascript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonw @fgregg