Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document datasette.urls.row and row_blob #1978

Closed
eyeseast opened this issue Jan 6, 2023 · 2 comments
Closed

Document datasette.urls.row and row_blob #1978

eyeseast opened this issue Jan 6, 2023 · 2 comments

Comments

@eyeseast
Copy link
Contributor

eyeseast commented Jan 6, 2023

These are in the codebase but not in documentation. I think everything else in this class is documented.

class Urls:
    ...
    def row(self, database, table, row_path, format=None):
        path = f"{self.table(database, table)}/{row_path}"
        if format is not None:
            path = path_with_format(path=path, format=format)
        return PrefixedUrlString(path)

    def row_blob(self, database, table, row_path, column):
        return self.table(database, table) + "/{}.blob?_blob_column={}".format(
            row_path, urllib.parse.quote_plus(column)
        )
@simonw
Copy link
Owner

simonw commented Jan 8, 2023

Related issue - I'm not 100% settled on the design for these yet:

@eyeseast
Copy link
Contributor Author

eyeseast commented Jan 9, 2023

Totally missed that issue. I can close this as a duplicate.

@eyeseast eyeseast closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants