Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form label { width: 15% } is a bad default #2150

Closed
simonw opened this issue Aug 23, 2023 · 4 comments
Closed

form label { width: 15% } is a bad default #2150

simonw opened this issue Aug 23, 2023 · 4 comments
Labels

Comments

@simonw
Copy link
Owner

simonw commented Aug 23, 2023

See:

@simonw simonw added the css label Aug 23, 2023
@simonw
Copy link
Owner Author

simonw commented Aug 23, 2023

form label {
font-weight: bold;
display: inline-block;
width: 15%;
}

@simonw
Copy link
Owner Author

simonw commented Aug 23, 2023

That should be scoped just to the query filters form on the table page.

I'll fix it in main but I'm still going to ship a fix for those plugins separately so they work well before people upgrade to the next Datasette release with this change in it.

@simonw
Copy link
Owner Author

simonw commented Aug 23, 2023

Looks like that affects a few forms:

CleanShot 2023-08-23 at 11 24 46@2x

The search form on the table page over-rides it already:

CleanShot 2023-08-23 at 11 25 26@2x

@simonw
Copy link
Owner Author

simonw commented Aug 23, 2023

I added outline: 3px dotted pink to that form label block to help spot where else it's being used.

Oh interesting, looks like it's over-ridden here too:

CleanShot 2023-08-23 at 11 27 15@2x

@simonw simonw closed this as completed in bdf59eb Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant